Skip to content

Conversation

DavisCacici
Copy link

@DavisCacici DavisCacici commented Feb 11, 2025

I suggest this update to the addObject method: if the resolver is undefined, provide a clear message to the user.

This isn't a fix issue but a better way

…ct is undefined

I suggest this update to the addObject method: if the resolver is undefined, provide a clear message to the user.
Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: f135094

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ardatan
Copy link
Member

ardatan commented Mar 7, 2025

Thanks for the PR! Could you add a changeset with "pnpm changeset" so we can bump the version with a proper changelog entry and could you also add a test to prevent future regression?

@DavisCacici
Copy link
Author

Sure, I'll do it as soon as possible!

@DavisCacici
Copy link
Author

Which test file should I add the test to?

@DavisCacici
Copy link
Author

I add test in context.spec.ts, if you want I can move it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants