Fix configuration and argument handling and documentation #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the documentation reflect reality since 062abc9.
That way tests can tell if they get the configured value because it was loaded from the configuration rather than ignored and the default substituted.
qha
force-pushed
the
tune-configuration-handling
branch
from
953918b to
dcd985b
Compare
... in ArgumentParserConfigTestCase.test_using_config.
Make it possible to set to both true and false in configuration files and less counterintuitive to set it to false from the command line.
…init__ Rename from disable_hashsum_verification which was not possible to pass through the argument parser.
qha
force-pushed
the
tune-configuration-handling
branch
from
dcd985b to
09cb79c
Compare
qha
changed the title
qha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Tune configuration handling and documentation.
Why
Mainly to fix ingestion of boolean keys from configuration files.
Also to fix ingestion of disable Notus hashsum verification from both command line and configuration.
Additionally to document all configuration options (that anyone might want to use) and the Notus specific arguments.
References
Checklist