missing_foreign_keys: Ignore tables which records are destroyed async #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnavis
requested changes
Apr 24, 2025
There was a problem hiding this comment.
@fatkodima, that's a great addition. I left some small comments.
fatkodima
force-pushed
the
consider-destroy_async
branch
from
d2351f9 to
81a24f6
Compare
|
Made updates. |
gregnavis
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, missing_foreign_keys erroneously suggests adding foreign keys to columns for rows, which are destroyed async from some other parent record. This PR fixes that.