Skip to content

Conversation

@fatkodima
Copy link
Contributor

Case insensitive columns in missing_unique_indexes checker were not properly ignored.

Copy link
Owner

@gregnavis gregnavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fatkodima, could you provide a bit more context on what this solves? I did a quick test and it seems that case-insensitive indexes can be ignored just fine via Context::User(email) (no need to call lower).

@fatkodima
Copy link
Contributor Author

I do not remember, but I think the problem was that the gem suggested adding an index on lower(column) and so people might think that the ignore would contain that lower too. lower(column) is not actually a column, but I think for a good ux the checker can accept both.

@gregnavis gregnavis removed the waiting label Aug 2, 2025
@gregnavis
Copy link
Owner

I think a proper solution here would be to perform more extensive configuration validation: the user should be told that lower(email) isn't a column. I think configuration validation was mentioned somewhere already in the context of identifying non-existent models, columns, attributes, and so on.

@gregnavis gregnavis closed this Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants