Rewrite missing_presence_validation to handle polymorphic associations #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits rewrites missing_presence_validation in a more imperative style with extensive commenting to make it clear why certain actions are performed. The new structure made it simple to correctly handle polymorphic associations: if a polymorphic foreign key is NOT NULL then the detector will suggest making the association as required, instead of suggesting adding validators for the _id and _type column separately.
This was referenced Aug 2, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR rewrites the missing_presence_validation detector to handle polymorphic associations correctly by suggesting association-level validation instead of separate validators for foreign key and type columns.
- Rewrote the detector logic in a more imperative style with extensive commenting for better maintainability
- Added proper handling for polymorphic associations to suggest
optional: falseinstead of separate column validators - Added test coverage for polymorphic association scenarios and configuration options
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/setup.rb |
Sets default Rails behavior for belongs_to associations to be required by default |
test/active_record_doctor/detectors/missing_presence_validation_test.rb |
Adds comprehensive test coverage for polymorphic association validation scenarios |
lib/active_record_doctor/detectors/missing_presence_validation.rb |
Complete rewrite of the detector logic to handle polymorphic associations and improve code clarity |
gregnavis
deleted the
163-missing-presence-validation-on-polymorphic-associations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits rewrites missing_presence_validation in a more imperative style with extensive commenting to make it clear why certain actions are performed. The new structure made it simple to correctly handle polymorphic associations: if a polymorphic foreign key is NOT NULL then the detector will suggest making the association as required, instead of suggesting adding validators for the _id and _type column separately.