-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
WIP: Include "child" assets in inventory email and other views #16842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@snipe @marcusmoore it's nice to see that it's finally coming to Snipe-IT. While you are working on 'Child assets' please consider adding 'Child accessories' to the views. Assets can have various items checked-out to it. For example, you could check-out DSLR camera that has various 'assets' (LENSE, FLASH, TRIPOD) and 'accessories' (memory card, strap, filter) checked-out to it and user could see a full list of items. |
@swift2512 that makes sense to me. It might not be included in this but can be addressed in the future. |
Here is the set up for the description that follows:
As pointed out in #16811, #13479 the email that is sent when clicking the "Email list of all Assigned" button does not include "child" assets (assets that are checked out to the assets checked out to the given user):

But they are included in the view for "Printing All Assigned":

This PR addresses that by including the child assets in the email along with the

x.x
numbering:In addition, I noticed that child assets were missing when viewing a user's assets (
/users/1#asset
) or your own asset's (/account/view-assets#assets
).I've add this to your viewing your own assets:
Before:
After:

Before:
fixes #13479