Skip to content

Fix console log uses debug #10139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix console log uses debug #10139

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98793f2
Fix: use console.debug (inspector verbose level) instead of console.l…
larzeni Jul 3, 2025
b2c103d
Fix: use console.debug (inspector verbose level) instead of console.l…
larzeni Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions user/src/com/google/gwt/logging/client/ConsoleLogHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public void publish(LogRecord record) {
} else if (val >= Level.INFO.intValue()) {
info(msg);
} else {
log(msg);
logVerbose(msg);
}
}

Expand All @@ -77,7 +77,9 @@ private native void info(String message) /*-{
window.console.info(message);
}-*/;

private native void log(String message) /*-{
window.console.log(message);
private native void logVerbose(String message) /*-{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the method to debug to match the naming scheme of all the other logging methods. Also the comment can be removed as it is already pretty clear what is going on.

// use console.debug to show FINE and FINEST messages
// only when "Verbose" is enabled in inspector
window.console.debug(message);
}-*/;
}