Performance increase #119
Merged
Performance increase #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahix
added a commit
to Rahix/serial-monitor-rust
that referenced
this pull request
Aug 25, 2025
When receiving only a single column of data, no graph would ever show up. This was due to the graph display data structure only being initialized when the number of datasets changes. However, the dataset attribute is populated with one entry by default, so when receiving a single column of data, the graph initialization never happens. Fix this by initializing the dataset structure to be empty by default. This bug was introduced in PR hacknus#119. Fixes: hacknus#119
Rahix
added a commit
to Rahix/serial-monitor-rust
that referenced
this pull request
Aug 25, 2025
It was no longer possible to update the labels and colors of the detected columns because they were always overwritten by the default values. Fix this by only settings label and color once after column changes, like it was done before. This bug was introduced in hacknus#119.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduces CPU load by removing a lot of
.clone()calls and switching frommpsctocrossbeam-channels