Skip to content

Fix grammatical errors in error messages regarding identity changes #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

NateBrady23
Copy link
Contributor

  • Updated error message in server_applyresourcechange_test.go to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
  • Updated error message in server_planresourcechange.go to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
  • Updated error message in server_planresourcechange_test.go to correct "then" to "than" in multiple instances of the "Unexpected Identity Change" diagnostic message.
  • Updated error message in server_readresource.go to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
  • Updated error message in server_readresource_test.go to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
  • Updated error message in server_updateresource.go to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.

Related: hashicorp/terraform-plugin-sdk#1499

- Updated error message in `server_applyresourcechange_test.go` to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
- Updated error message in `server_planresourcechange.go` to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
- Updated error message in `server_planresourcechange_test.go` to correct "then" to "than" in multiple instances of the "Unexpected Identity Change" diagnostic message.
- Updated error message in `server_readresource.go` to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
- Updated error message in `server_readresource_test.go` to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
- Updated error message in `server_updateresource.go` to correct "then" to "than" in the "Unexpected Identity Change" diagnostic message.
Copy link

hashicorp-cla-app bot commented Jun 30, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @NateBrady23 ! For this PR you'll also need to sign the CLA before I can merge it, but the changes/tests look good 👍🏻

@NateBrady23
Copy link
Contributor Author

@austinvalle No problem! CLA signed.

Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated! 🚀

@austinvalle austinvalle merged commit 099347e into hashicorp:main Jun 30, 2025
5 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants