Skip to content

Allow RequiresReplace plan modifier to run for write-only attributes #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow RequiresReplace plan modifier to run for write-only attributes #1227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e09c69
Allow requiresreplace plan modifier to run for write-only attributes
yottta Sep 18, 2025
b4e37fb
Merge branch 'main' into main
yottta Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions internal/fwserver/attribute_plan_modification.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,6 +786,7 @@ func AttributePlanModifyBool(ctx context.Context, attribute fwxschema.AttributeW
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.BoolPlanModifiers() {
Expand Down Expand Up @@ -946,6 +947,7 @@ func AttributePlanModifyFloat32(ctx context.Context, attribute fwxschema.Attribu
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.Float32PlanModifiers() {
Expand Down Expand Up @@ -1106,6 +1108,7 @@ func AttributePlanModifyFloat64(ctx context.Context, attribute fwxschema.Attribu
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.Float64PlanModifiers() {
Expand Down Expand Up @@ -1266,6 +1269,7 @@ func AttributePlanModifyInt32(ctx context.Context, attribute fwxschema.Attribute
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.Int32PlanModifiers() {
Expand Down Expand Up @@ -1426,6 +1430,7 @@ func AttributePlanModifyInt64(ctx context.Context, attribute fwxschema.Attribute
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.Int64PlanModifiers() {
Expand Down Expand Up @@ -1586,6 +1591,7 @@ func AttributePlanModifyList(ctx context.Context, attribute fwxschema.AttributeW
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.ListPlanModifiers() {
Expand Down Expand Up @@ -1746,6 +1752,7 @@ func AttributePlanModifyMap(ctx context.Context, attribute fwxschema.AttributeWi
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.MapPlanModifiers() {
Expand Down Expand Up @@ -1906,6 +1913,7 @@ func AttributePlanModifyNumber(ctx context.Context, attribute fwxschema.Attribut
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.NumberPlanModifiers() {
Expand Down Expand Up @@ -2066,6 +2074,7 @@ func AttributePlanModifyObject(ctx context.Context, attribute fwxschema.Attribut
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.ObjectPlanModifiers() {
Expand Down Expand Up @@ -2386,6 +2395,7 @@ func AttributePlanModifyString(ctx context.Context, attribute fwxschema.Attribut
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.StringPlanModifiers() {
Expand Down Expand Up @@ -2546,6 +2556,7 @@ func AttributePlanModifyDynamic(ctx context.Context, attribute fwxschema.Attribu
Private: req.Private,
State: req.State,
StateValue: stateValue,
WriteOnly: attribute.IsWriteOnly(),
}

for _, planModifier := range attribute.DynamicPlanModifiers() {
Expand Down
Loading