fix: aws_rds_cluster needs performance insights retention passed to nable database insights

[ebachle]

Description

This resolves an issue where if performance insights retention period had already been set on an RDS Cluster, there is no has_change on that input and it is not passed as required to the upstream API for RDS and results in a 400.

An example AWS CLI error occurs when this is performed on a database with performance insights already enabled and set to the right retention window, but the retention window isn't passed.

aws rds modify-db-cluster  --db-cluster-identifier test --database-insights-mode advanced --enable-performance-insights

An error occurred (InvalidParameterCombination) when calling the ModifyDBCluster operation: To enable the Advanced mode of Database Insights, modify your cluster to enable Performance Insights and set the retention period for Performance Insights to at least 465 days.

Relations

Closes #42539

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRDSCluster_databaseInsightsMode_update PKG=rds

I don't have a default VPC, so it's barfing errors.  I can try to fix it if it's absolutely required.
...

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.