Skip to content

fix: mark aws_route53profiles_resource_association resource_properties as Computed #42562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aristosvo
Copy link
Contributor

@aristosvo aristosvo commented May 10, 2025

Description

Mark aws_route53profiles_resource_association resource_properties attribute as Computed to enable aws_vpc_endpoint association.

Relations

Closes #42558
Closes #42489

References

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53ProfilesResourceAssociation_vpcEndpoint PKG=route53profiles 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/route53profiles/... -v -count 1 -parallel 20 -run='TestAccRoute53ProfilesResourceAssociation_vpcEndpoint'  -timeout 360m -vet=off
2025/05/10 11:38:58 Initializing Terraform AWS Provider...
=== RUN   TestAccRoute53ProfilesResourceAssociation_vpcEndpoint
=== PAUSE TestAccRoute53ProfilesResourceAssociation_vpcEndpoint
=== CONT  TestAccRoute53ProfilesResourceAssociation_vpcEndpoint
--- PASS: TestAccRoute53ProfilesResourceAssociation_vpcEndpoint (1305.10s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53profiles    1308.362s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/route53profiles Issues and PRs that pertain to the route53profiles service. size/M Managed by automation to categorize the size of a PR. external-maintainer Contribution from a trusted external contributor. labels May 10, 2025
@aristosvo aristosvo force-pushed the b-aws_route53profiles_resource_association-resource_properties-computed branch from eaaedd5 to 20093c4 Compare May 10, 2025 09:02
@aristosvo aristosvo marked this pull request as ready for review May 10, 2025 09:05
@aristosvo aristosvo requested a review from a team as a code owner May 10, 2025 09:05
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. service/route53profiles Issues and PRs that pertain to the route53profiles service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants