Skip to content

r/aws_codebuild_fleet: support for proxy_configuration #42566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

badmintoncryer
Copy link
Contributor

Description

This change adds a proxy_configuration argument to the AWS CodeBuild Fleet resource.
This argument enables users to configure proxy rules for network connectivity in CodeBuild Fleet, allowing access control to specific domains and IP addresses.

Added features:

  • Support for proxy_configuration block
    • default_behavior - Sets the default proxy behavior (ALLOW_ALL or DENY_ALL)
    • ordered_proxy_rules - Configures a list of proxy rules
      • effect - The effect of the rule (ALLOW or DENY)
      • type - The type of rule (DOMAIN or IP)
      • entities - A list of entities to which the rule applies

Relations

None

References

https://docs.aws.amazon.com/ja_jp/codebuild/latest/APIReference/API_CreateFleet.html#CodeBuild-CreateFleet-request-proxyConfiguration

Output from Acceptance Testing

make testacc TESTS=TestAccCodeBuildFleet_proxyConfiguration PKG=codebuild
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/codebuild/... -v -count 1 -parallel 20 -run='TestAccCodeBuildFleet_proxyConfiguration'  -timeout 360m -vet=off
2025/05/11 23:47:09 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeBuildFleet_proxyConfiguration
=== PAUSE TestAccCodeBuildFleet_proxyConfiguration
=== CONT  TestAccCodeBuildFleet_proxyConfiguration
--- PASS: TestAccCodeBuildFleet_proxyConfiguration (186.56s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  194.006s

@badmintoncryer badmintoncryer requested a review from a team as a code owner May 11, 2025 15:05
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link

github-actions bot commented May 11, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. size/XL Managed by automation to categorize the size of a PR. labels May 11, 2025
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label May 11, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants