Skip to content

aws_sagemaker_image_version - add support for alias fixes #35931 #42610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/6.0.0-beta
Choose a base branch
from

Conversation

psantus
Copy link
Contributor

@psantus psantus commented May 14, 2025

Description

Adds support for aliases in aws_sagemaker_image_versionresource.

It required to refactor resourceImageVersionRead because the AWS SDK doesn't have an Aliases field in DescribeImageVersionOutput.

Identical to #42609 but rebased on 6.0.0-beta.

Relations

Closes #35931

References

CreateImageVersion supports aliases
DescribeImageVersion doesn't return aliases
But we have a handy ListAliases API that helps

Output from Acceptance Testing

% cd ./internal/service/sagemaker && TF_ACC=1 SAGEMAKER_IMAGE_VERSION_BASE_IMAGE=<REDACTED>.dkr.ecr.us-west-2.amazonaws.com/terraform-test:latest AWS_PROFILE=<REDACTED> go test -v -run="TestAccSageMakerImageVersion_update" -count=1

2025/05/14 11:39:20 Creating Terraform AWS Provider (SDKv2-style)...
2025/05/14 11:39:20 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccSageMakerImageVersion_update
=== PAUSE TestAccSageMakerImageVersion_update
=== CONT  TestAccSageMakerImageVersion_update
--- PASS: TestAccSageMakerImageVersion_update (113.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  117.300s

...

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. labels May 14, 2025
@psantus psantus force-pushed the f/sagemaker_image_version-add-missing-metadata-rebased-6.0.0 branch from 67df62e to ee378f9 Compare May 14, 2025 09:42
@psantus psantus marked this pull request as ready for review May 14, 2025 09:43
@psantus psantus requested a review from a team as a code owner May 14, 2025 09:43
@psantus psantus force-pushed the f/sagemaker_image_version-add-missing-metadata-rebased-6.0.0 branch from ee378f9 to 9b09984 Compare May 14, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant