Skip to content

[New Data Source] aws_cloudfront_key_value_store #42630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

tabito-hara
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • Added a new data source, aws_cloudfront_key_value_store, to retrieve attributes of a CloudFront Key Value Store, such as its ARN.

    • When using aws_cloudfrontkeyvaluestore_key, the ARN of the Key Value Store must be specified. This new data source makes it easier to work with an existing Key Value Store.

Relations

Closes #42530

References

https://docs.aws.amazon.com/ja_jp/cloudfront/latest/APIReference/API_DescribeKeyValueStore.html

Output from Acceptance Testing

$ make testacc TESTS=TestAccCloudFrontKeyValueStoreDataSource_ PKG=cloudfront               
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontKeyValueStoreDataSource_'  -timeout 360m -vet=off
2025/05/16 01:32:49 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontKeyValueStoreDataSource_basic
=== PAUSE TestAccCloudFrontKeyValueStoreDataSource_basic
=== CONT  TestAccCloudFrontKeyValueStoreDataSource_basic
--- PASS: TestAccCloudFrontKeyValueStoreDataSource_basic (36.97s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 40.557s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. generators Relates to code generators. size/L Managed by automation to categorize the size of a PR. labels May 15, 2025
@tabito-hara tabito-hara marked this pull request as ready for review May 15, 2025 17:17
@tabito-hara tabito-hara requested a review from a team as a code owner May 15, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/cloudfront Issues and PRs that pertain to the cloudfront service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add data source support for aws_cloudfront_key_value_store
1 participant