Skip to content

[Enhancement] aws_cognito_user_pool: Update name attribute without resource replacement #42639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tabito-hara
Copy link
Contributor

@tabito-hara tabito-hara commented May 15, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

  • With this modification, the name attribute of the aws_cognito_user_pool resource can now be updated in-place. Previously, changing this attribute required replacing the resource.
  • Added an acceptance test to verify that the name attribute is updated in-place — i.e., the resource ID does not change during the update.

Relations

Closes #42627

References

https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider#UpdateUserPoolInput
name attribute is included in type UpdateUserPoolInput

Output from Acceptance Testing

$ make testacc TESTS=TestAccCognitoIDPUserPool_ PKG=cognitoidp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.8 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPool_'  -timeout 360m -vet=off
2025/05/16 08:21:13 Initializing Terraform AWS Provider...
=== RUN   TestAccCognitoIDPUserPool_tags
=== PAUSE TestAccCognitoIDPUserPool_tags
=== RUN   TestAccCognitoIDPUserPool_tags_null
=== PAUSE TestAccCognitoIDPUserPool_tags_null
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyMap
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyMap
=== RUN   TestAccCognitoIDPUserPool_tags_AddOnUpdate
=== PAUSE TestAccCognitoIDPUserPool_tags_AddOnUpdate
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate
=== PAUSE TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate
=== RUN   TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccCognitoIDPUserPool_basic
=== PAUSE TestAccCognitoIDPUserPool_basic
=== RUN   TestAccCognitoIDPUserPool_deletionProtection
=== PAUSE TestAccCognitoIDPUserPool_deletionProtection
=== RUN   TestAccCognitoIDPUserPool_recovery
=== PAUSE TestAccCognitoIDPUserPool_recovery
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUser
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUser
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== PAUSE TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== RUN   TestAccCognitoIDPUserPool_withAdvancedSecurityAdditionalFlows
=== PAUSE TestAccCognitoIDPUserPool_withAdvancedSecurityAdditionalFlows
=== RUN   TestAccCognitoIDPUserPool_withDevice
=== PAUSE TestAccCognitoIDPUserPool_withDevice
=== RUN   TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_passwordHistorySize
=== PAUSE TestAccCognitoIDPUserPool_passwordHistorySize
=== RUN   TestAccCognitoIDPUserPool_MFA_sms
=== PAUSE TestAccCognitoIDPUserPool_MFA_sms
=== RUN   TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_emailConfigurationMFA
    user_pool_test.go:657: Environment variable TEST_AWS_SES_VERIFIED_EMAIL_ARN is not set, skipping test
--- SKIP: TestAccCognitoIDPUserPool_MFA_emailConfigurationMFA (0.00s)
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== RUN   TestAccCognitoIDPUserPool_signInPolicy
=== PAUSE TestAccCognitoIDPUserPool_signInPolicy
=== RUN   TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== RUN   TestAccCognitoIDPUserPool_sms
=== PAUSE TestAccCognitoIDPUserPool_sms
=== RUN   TestAccCognitoIDPUserPool_SMS_snsRegion
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsRegion
=== RUN   TestAccCognitoIDPUserPool_SMS_externalID
=== PAUSE TestAccCognitoIDPUserPool_SMS_externalID
=== RUN   TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== RUN   TestAccCognitoIDPUserPool_smsVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_withEmail
=== PAUSE TestAccCognitoIDPUserPool_withEmail
=== RUN   TestAccCognitoIDPUserPool_withEmailSource
    user_pool_test.go:1038: Environment variable TEST_AWS_SES_VERIFIED_EMAIL_ARN is not set, skipping test
--- SKIP: TestAccCognitoIDPUserPool_withEmailSource (0.00s)
=== RUN   TestAccCognitoIDPUserPool_withAliasAttributes
=== PAUSE TestAccCognitoIDPUserPool_withAliasAttributes
=== RUN   TestAccCognitoIDPUserPool_withUsernameAttributes
=== PAUSE TestAccCognitoIDPUserPool_withUsernameAttributes
=== RUN   TestAccCognitoIDPUserPool_withPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_usernameConfiguration
=== PAUSE TestAccCognitoIDPUserPool_usernameConfiguration
=== RUN   TestAccCognitoIDPUserPool_withLambda
=== PAUSE TestAccCognitoIDPUserPool_withLambda
=== RUN   TestAccCognitoIDPUserPool_WithLambda_email
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_email
=== RUN   TestAccCognitoIDPUserPool_WithLambda_sms
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_sms
=== RUN   TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== RUN   TestAccCognitoIDPUserPool_addLambda
=== PAUSE TestAccCognitoIDPUserPool_addLambda
=== RUN   TestAccCognitoIDPUserPool_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributes
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesModified
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesModified
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== RUN   TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== PAUSE TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== RUN   TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
=== PAUSE TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
=== RUN   TestAccCognitoIDPUserPool_webAuthnConfiguration
=== PAUSE TestAccCognitoIDPUserPool_webAuthnConfiguration
=== RUN   TestAccCognitoIDPUserPool_update
=== PAUSE TestAccCognitoIDPUserPool_update
=== RUN   TestAccCognitoIDPUserPool_disappears
=== PAUSE TestAccCognitoIDPUserPool_disappears
=== RUN   TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== PAUSE TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== RUN   TestAccCognitoIDPUserPool_userPoolTier
=== PAUSE TestAccCognitoIDPUserPool_userPoolTier
=== RUN   TestAccCognitoIDPUserPool_nameUpdate
=== PAUSE TestAccCognitoIDPUserPool_nameUpdate
=== CONT  TestAccCognitoIDPUserPool_tags
=== CONT  TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== CONT  TestAccCognitoIDPUserPool_userPoolTier
=== CONT  TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== CONT  TestAccCognitoIDPUserPool_basic
=== CONT  TestAccCognitoIDPUserPool_usernameConfiguration
=== CONT  TestAccCognitoIDPUserPool_nameUpdate
=== CONT  TestAccCognitoIDPUserPool_SMS_externalID
=== CONT  TestAccCognitoIDPUserPool_SMS_snsRegion
=== CONT  TestAccCognitoIDPUserPool_sms
=== CONT  TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== CONT  TestAccCognitoIDPUserPool_signInPolicy
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== CONT  TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== CONT  TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== CONT  TestAccCognitoIDPUserPool_MFA_sms
=== CONT  TestAccCognitoIDPUserPool_passwordHistorySize
=== CONT  TestAccCognitoIDPUserPool_schemaAttributes
--- PASS: TestAccCognitoIDPUserPool_signInPolicy (41.91s)
=== CONT  TestAccCognitoIDPUserPool_addLambda
--- PASS: TestAccCognitoIDPUserPool_basic (43.40s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy (46.83s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_sms
--- PASS: TestAccCognitoIDPUserPool_SMS_snsRegion (66.86s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_email
--- PASS: TestAccCognitoIDPUserPool_smsAuthenticationMessage (71.31s)
=== CONT  TestAccCognitoIDPUserPool_withLambda
--- PASS: TestAccCognitoIDPUserPool_passwordHistorySize (72.59s)
=== CONT  TestAccCognitoIDPUserPool_recovery
--- PASS: TestAccCognitoIDPUserPool_userPoolTier (72.62s)
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUser
--- PASS: TestAccCognitoIDPUserPool_nameUpdate (72.79s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
--- PASS: TestAccCognitoIDPUserPool_withEmailVerificationMessage (74.33s)
=== CONT  TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
--- PASS: TestAccCognitoIDPUserPool_schemaAttributes (74.49s)
=== CONT  TestAccCognitoIDPUserPool_disappears
--- PASS: TestAccCognitoIDPUserPool_usernameConfiguration (77.86s)
=== CONT  TestAccCognitoIDPUserPool_update
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS (88.21s)
=== CONT  TestAccCognitoIDPUserPool_webAuthnConfiguration
--- PASS: TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA (94.39s)
=== CONT  TestAccCognitoIDPUserPool_withAliasAttributes
--- PASS: TestAccCognitoIDPUserPool_SMS_externalID (96.32s)
=== CONT  TestAccCognitoIDPUserPool_withPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFA (99.15s)
=== CONT  TestAccCognitoIDPUserPool_withUsernameAttributes
--- PASS: TestAccCognitoIDPUserPool_SMS_snsCallerARN (107.43s)
=== CONT  TestAccCognitoIDPUserPool_withAdvancedSecurityAdditionalFlows
--- PASS: TestAccCognitoIDPUserPool_disappears (34.80s)
=== CONT  TestAccCognitoIDPUserPool_withDevice
--- PASS: TestAccCognitoIDPUserPool_sms (109.92s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA (122.39s)
=== CONT  TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccCognitoIDPUserPool_webAuthnConfiguration (34.77s)
--- PASS: TestAccCognitoIDPUserPool_addLambda (93.32s)
=== CONT  TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings (61.37s)
=== CONT  TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccCognitoIDPUserPool_MFA_sms (136.70s)
=== CONT  TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8 (71.04s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUser (74.60s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccCognitoIDPUserPool_tags (174.98s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccCognitoIDPUserPool_withAliasAttributes (91.34s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccCognitoIDPUserPool_recovery (117.41s)
=== CONT  TestAccCognitoIDPUserPool_deletionProtection
--- PASS: TestAccCognitoIDPUserPool_withPasswordPolicy (94.29s)
=== CONT  TestAccCognitoIDPUserPool_withAdvancedSecurityMode
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (148.31s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
--- PASS: TestAccCognitoIDPUserPool_withUsernameAttributes (96.52s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityAdditionalFlows (100.16s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplate
--- PASS: TestAccCognitoIDPUserPool_withDevice (102.95s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccCognitoIDPUserPool_WithLambda_sms (166.78s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesModified
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate (85.50s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag (78.75s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping
--- PASS: TestAccCognitoIDPUserPool_update (149.90s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesRemoved
--- PASS: TestAccCognitoIDPUserPool_WithLambda_email (161.15s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly (119.65s)
=== CONT  TestAccCognitoIDPUserPool_withEmail
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag (85.13s)
=== CONT  TestAccCognitoIDPUserPool_smsVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_withLambda (173.58s)
=== CONT  TestAccCognitoIDPUserPool_tags_AddOnUpdate
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag (83.44s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints (70.28s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag (78.38s)
=== CONT  TestAccCognitoIDPUserPool_tags_null
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace (132.51s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyMap
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add (136.19s)
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag (152.00s)
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesModified (61.96s)
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesRemoved (59.36s)
--- PASS: TestAccCognitoIDPUserPool_withEmail (60.02s)
--- PASS: TestAccCognitoIDPUserPool_deletionProtection (107.61s)
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag (177.75s)
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplate (96.59s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace (110.81s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly (102.46s)
--- PASS: TestAccCognitoIDPUserPool_smsVerificationMessage (84.92s)
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityMode (130.80s)
--- PASS: TestAccCognitoIDPUserPool_tags_null (61.43s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyMap (59.83s)
--- PASS: TestAccCognitoIDPUserPool_tags_AddOnUpdate (84.04s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate (79.54s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping (125.28s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping (126.11s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add (94.97s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly (137.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 369.937s

Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/S Managed by automation to categorize the size of a PR. labels May 15, 2025
@tabito-hara tabito-hara changed the title F aws cognito user pool update name in place [Enhancement] aws_cognito_user_pool: Update name attribute without resource replacement May 15, 2025
@tabito-hara tabito-hara marked this pull request as ready for review May 15, 2025 23:52
@tabito-hara tabito-hara requested a review from a team as a code owner May 15, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Waiting for first response or review from a maintainer. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support renaming of aws_cognito_user_pool
1 participant