Skip to content

Conversation

LoopyLulu
Copy link

@LoopyLulu LoopyLulu commented Aug 15, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No

Description

The guardrails topic definition used to be capped at 200 characters. Since they released the standard tier, the character limit for that tier is set to 1000 characters. Standard tier: 1-1000 chars Classic tier: 1-200 chars.

I added updated the original validator to be 1000, and added an additional validation check to ensure that Classic tier definitions still have to be between 1-200.

Relations

N/A

References

N/A

Output from Acceptance Testing

I tested via these test cases:
Standard with definition <= 1000 is good
Standard with definition > 1000 has error
Classic with definition <= 200 is good
Classic with definition > 200 has error
image

% make testacc TESTS=TestAccBedrockGuardrail_basic PKG=bedrock
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockGuardrail_basic'  -timeout 360m -vet=off
2025/08/15 12:30:17 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/15 12:30:17 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccBedrockGuardrail_basic
=== PAUSE TestAccBedrockGuardrail_basic
=== CONT  TestAccBedrockGuardrail_basic
--- PASS: TestAccBedrockGuardrail_basic (11.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrock	15.856s
...

@LoopyLulu LoopyLulu requested a review from a team as a code owner August 15, 2025 15:22
Copy link
Contributor

github-actions bot commented Aug 15, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/bedrock Issues and PRs that pertain to the bedrock service. size/M Managed by automation to categorize the size of a PR. labels Aug 15, 2025
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Addresses a defect in current functionality. service/bedrock Issues and PRs that pertain to the bedrock service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants