Skip to content

Conversation

MatthewJohn
Copy link
Contributor

Rollback Plan

No rollback plan necessary

Changes to Security Controls

None

Description

The resource explicitly ignored changes to tags and did not make use of the UpdateTags SDK method. This means that tags of aws_ecs_service resources could not be modified.

This implements a call to update tags during resource updates.

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. labels Oct 8, 2025
@MatthewJohn MatthewJohn marked this pull request as ready for review October 8, 2025 15:06
@MatthewJohn MatthewJohn requested a review from a team as a code owner October 8, 2025 15:06
@MatthewJohn MatthewJohn force-pushed the f-fix-tag-updates-to-ecs-service branch 2 times, most recently from 8f2df4d to 165989c Compare October 9, 2025 07:09
@MatthewJohn MatthewJohn force-pushed the f-fix-tag-updates-to-ecs-service branch from 165989c to 6b92d19 Compare October 9, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant