PSS: Implement unsetting of a state store #37875
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
the
no-changelog-needed
radeksimko
force-pushed
the
radek/pss-init-migration
branch
13 times, most recently
from
e805230 to
9003bdb
Compare
radeksimko
commented
Nov 11, 2025
SarahFrench
reviewed
Nov 12, 2025
Member
SarahFrench
left a comment
SarahFrench
left a comment
There was a problem hiding this comment.
Looks good to me, I've left some comments about moving where we test things and some thoughts about what code should be used to obtain a provider factory to match backend state file data (plus some nits).
As of Go 1.16, this function simply calls os.ReadFile
radeksimko
force-pushed
the
radek/pss-init-migration
branch
from
a56c80c to
d6e63cd
Compare
SarahFrench
reviewed
Nov 18, 2025
Member
SarahFrench
left a comment
SarahFrench
left a comment
There was a problem hiding this comment.
Other than this last bit, this PR looks good to me: #37875 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements migration from an existing
state_storeto a "local" state (i.e. no state store, no backend).I decided to remove the
ProviderFactoryabstraction layer because it was getting in the way of the migration related logic. In particular, when unsetting a state store, we can no longer rely on configuration driving the factory creation.More importantly if/when we update the UI such that we no longer execute plugins straight after installing them we should be able to just rely on the lockfile "file cache" everywhere and then we can also get rid of the
BackendOpts.Locks.I would strongly recommend reviewing each of the two commits separately to avoid getting lost in the
weedslarge diffs.Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry