Skip to content

New feature: reversible sort links #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions flask_bootstrap/templates/base/utils.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,48 @@
{{ url_for(endpoint, **kargs) }}
{%- endwith %}
{%- endmacro %}


{% macro render_sortlink(
attr,
text = attr | title,
icon_asc = config.BOOTSTRAP_SORT_ICON_ASC or "caret-up",
icon_desc = config.BOOTSTRAP_SORT_ICON_DESC or "caret-down",
sort_style = config.BOOTSTRAP_SORT_STYLE or "csv",
sort_param = config.BOOTSTRAP_SORT_PARAM or "sort",
sort_dir_param = config.BOOTSTRAP_SORT_DIR_PARAM or "dir",
sort_asc_value = config.BOOTSTRAP_SORT_ASC_VALUE or "asc",
sort_desc_value = config.BOOTSTRAP_SORT_DESC_VALUE or "desc",
sort_title_template = config.SORT_TITLE_TEMPLATE or "Sort %s (%s)",
sort_value_name_map = config.SORT_VALUE_NAME_MAP or {"asc": "Ascending", "desc": "Descending"},
link_attrs = {}
) %}

{% if sort_style == "csv" %}
{% set curr_attr, _, curr_dir = request.args.get(sort_param, "").partition(",")%}
{% else %}
{% set curr_attr = request.args.get(sort_param) %}
{% set curr_dir = request.args.get(sort_dir_param) %}
{% endif %}

{% set desired_dir = sort_desc_value if curr_attr == attr and curr_dir == sort_asc_value else
sort_asc_value %}

{% set args = request.args.copy() %}

{% if sort_style == "csv" %}
{% set _ = args.setlist(sort_param, ["%s,%s" | format(attr, desired_dir)])%}
{% else %}
{% set _ = args.setlist(sort_param, [attr])%}
{% set _ = args.setlist(sort_dir_param, [desired_dir]) %}
{% endif %}

{% if sort_title_template %}
{% set _ = link_attrs.update({"title":sort_title_template | format(text, sort_value_name_map[desired_dir])}) %}
{% endif %}

<span class="text-nowrap">
<a href="{{url_for(request.endpoint, **args)}}" {{link_attrs|xmlattr}}>{{text}}</a>
{{render_icon(icon_asc if desired_dir == sort_desc_value else icon_desc) if attr == curr_attr}}
</span>
{% endmacro %}
24 changes: 24 additions & 0 deletions tests/test_bootstrap4/test_render_sortlink.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
from flask import render_template_string


def test_render_sortlink(app, client):
@app.route("/sortlink")
def sortlink():
return render_template_string(
"""
{% from 'bootstrap4/utils.html' import render_sortlink %}
{{ render_sortlink('foo') }}
"""
)

response = client.get("/sortlink")
data = response.get_data(as_text=True)
assert "?sort=foo,asc" in data

response = client.get("/sortlink?sort=foo,asc")
data = response.get_data(as_text=True)
assert "?sort=foo,desc" in data

response = client.get("/sortlink?sort=foo,desc")
data = response.get_data(as_text=True)
assert "?sort=foo,asc" in data