This repository was archived by the owner on Mar 16, 2024. It is now read-only.
Fixing partial url for quay.io #38
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Fixes #27 |
hipyhop
approved these changes
Oct 30, 2019
|
Sorry to bother you @Myrcurial , but would it be possible to merge it? |
|
I'm not comfortable with that operation @sbres -- there may be more appropriate people to do this work. |
|
Sorry, Edward Muller account said to ping you. If there is someone you know could merge this, could you ping him ? |
|
@sbres Ok - @cfunkhouser can you look at this request from @sbres and see if it's reasonable to do the merge? |
|
Hi, can this change be merged as this would resolve the issue I'm also experiencing with Quay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quay.io returns "next page" links like '/v2/....' vs including fully qualified URLs. This patch does the URL join with the registry URL to get a proper fully qualified URL