fix: add compound variant array className to base when slot key is unspecified #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When having multiple slots, and not specifying the slot key in
compoundVariants
, like:Conveniently, the class
truncate
is added tobase
. However, ifclass
is an array like:While one would expect the same behavior, the
truncate
class is not passed anywhere, even though it's type-safe. The reason is that the condition that adds the class to thebase
slot, only checks fortypeof class === "string"
.This PR adds an additional check for
Array.isArray
. I have modified one of the tests, so it fails without the added check. Let me know if the PR can be improved in any way.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).