HHH-19737 - Support Envers with StatelessSession #10753
Open
+3,335
−1,671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
sebersole
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -29,7 +29,7 @@ | |||
| handlePostUpsert( event.getEntity(), event.getSession() ); | |||
| } | |||
|
|
|||
| private void handlePostUpsert(Object entity, EventSource source) { | |||
| private void handlePostUpsert(Object entity, SharedSessionContractImplementor source) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -29,7 +29,7 @@ | |||
| handlePostUpsert( event.getEntity(), event.getSession() ); | |||
| } | |||
|
|
|||
| private void handlePostUpsert(Object entity, EventSource source) { | |||
| private void handlePostUpsert(Object entity, SharedSessionContractImplementor source) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
| revisionInfoGenerator.saveRevisionData( session, revisionData ); | ||
| } | ||
| } | ||
| else if ( session instanceof StatelessSessionImplementor statelessSession ) { |
Check notice
Code scanning / CodeQL
Unread local variable
| @@ -34,7 +33,7 @@ | |||
| * @param currentRevisionData Revision log entity. | |||
| * @param vwu Performed work unit. | |||
| */ | |||
| public void entityChanged(Session session, Object currentRevisionData, AuditWorkUnit vwu) { | |||
| public void entityChanged(SharedSessionContractImplementor session, Object currentRevisionData, AuditWorkUnit vwu) { | |||
Check notice
Code scanning / CodeQL
Useless parameter
# Conflicts: # hibernate-core/src/main/java/org/hibernate/engine/spi/AbstractDelegatingSharedSessionBuilder.java # hibernate-core/src/main/java/org/hibernate/event/internal/DefaultLockEventListener.java # hibernate-core/src/main/java/org/hibernate/internal/StatelessSessionImpl.java # Conflicts: # hibernate-core/src/main/java/org/hibernate/cache/internal/CollectionCacheInvalidator.java
| @Override | ||
| SharedStatelessSessionBuilder noInterceptor(); | ||
|
|
||
| SharedStatelessSessionBuilder statementInspector(UnaryOperator<String> operator); |
Check notice
Code scanning / CodeQL
Missing Override annotation
| SessionBuilderImplementor tenantIdentifier(String tenantIdentifier); | ||
|
|
||
| @Override | ||
| SessionBuilderImplementor tenantIdentifier(Object tenantIdentifier); |
Check notice
Code scanning / CodeQL
Confusing overloading of methods
sebersole
force-pushed
the
EventSource
branch
from
656262d to
db819d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invesigate proper support for certain events (
AbstractDatabaseOperationEventand friends) fromStatelessSession.hibernate/hibernate-reactive#394
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19737