Skip to content

Conversation

kingg22
Copy link

@kingg22 kingg22 commented Aug 27, 2025

[Please describe here what your change is about]

#hibernate-orm-dev > Null safe and build time


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Aug 27, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [c627cf3, ad2ccc2, 1884c37, 03b118a, b4dfb56, dfb61b2, 0f85a39, 9120feb, 959d71c, a48655f, 0611ad3]

› This message was automatically generated.

@kingg22 kingg22 force-pushed the perf/null-annotations branch from 284516e to e6b978e Compare August 27, 2025 21:08
@kingg22 kingg22 force-pushed the perf/null-annotations branch from e6b978e to 0611ad3 Compare August 27, 2025 21:09
@beikov
Copy link
Member

beikov commented Aug 28, 2025

Is the null check even running? The H2 run still takes 19 minutes, so it seems like there is no compile time "regression" when using this plugin.

@kingg22
Copy link
Author

kingg22 commented Aug 28, 2025

Hi, yes, the plugin is running, but don't have better performance in GH action (The difference is ~1-3 min but it could be because of the environment).
Yesterday I did an experiment with hibernate core and have more than 10 k error in 2 minutes with gradlew assemble.
Can you try to do a change in hibernate processor and work locally as you always do to check if there is improvement or if it is the same as before? I think the improvement of this change is seen more locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants