Skip to content

fix: Add nexus config to enable protobuf publish #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

Nana-EC
Copy link
Contributor

@Nana-EC Nana-EC commented May 22, 2025

Reviewer Notes

protobuf jar publishing was broken

  • Add nexus config to unblock

Related Issue(s)

Fixes #1187

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
@Nana-EC Nana-EC added this to the 0.12.0 milestone May 22, 2025
@Nana-EC Nana-EC self-assigned this May 22, 2025
@Nana-EC Nana-EC added the Release Issues tied to release management functions label May 22, 2025
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
@Nana-EC Nana-EC marked this pull request as ready for review May 23, 2025 16:32
@Nana-EC Nana-EC requested a review from a team as a code owner May 23, 2025 16:32
@Nana-EC Nana-EC requested a review from rbarker-dev May 23, 2025 16:32
@Nana-EC Nana-EC changed the title Add nexus config to enable protobuf publish fix: Add nexus config to enable protobuf publish May 23, 2025
Copy link
Member

@rbarker-dev rbarker-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nana-EC Nana-EC merged commit 1abe07e into main May 23, 2025
17 of 21 checks passed
@Nana-EC Nana-EC deleted the 1187-fix-publish-proto-jar branch May 23, 2025 16:51
Nana-EC added a commit that referenced this pull request May 23, 2025
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
@AlfredoG87 AlfredoG87 added Improvement Code changes driven by non business requirements Bug A error that causes the feature to behave differently than what was expected based on design docs and removed Improvement Code changes driven by non business requirements labels Jun 12, 2025
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

@@             Coverage Diff              @@
##               main    #1188      +/-   ##
============================================
+ Coverage     84.54%   84.59%   +0.05%     
- Complexity      912      914       +2     
============================================
  Files           105      105              
  Lines          3726     3726              
  Branches        399      399              
============================================
+ Hits           3150     3152       +2     
+ Misses          422      421       -1     
+ Partials        154      153       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs Release Issues tied to release management functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish-protobuf-jar fails
3 participants