-
Notifications
You must be signed in to change notification settings - Fork 8
fix: Add nexus config to enable protobuf publish #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
rbarker-dev
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AlfredoG87
approved these changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nana-EC
added a commit
that referenced
this pull request
May 23, 2025
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1188 +/- ##
============================================
+ Coverage 84.54% 84.59% +0.05%
- Complexity 912 914 +2
============================================
Files 105 105
Lines 3726 3726
Branches 399 399
============================================
+ Hits 3150 3152 +2
+ Misses 422 421 -1
+ Partials 154 153 -1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
protobuf jar publishing was broken
Related Issue(s)
Fixes #1187