build: add 'protobuf' files to published Jar #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jendrik Johannes <jendrik.johannes@gmail.com>
jjohannes
force-pushed
the
protobuf-sources-publish-fix
branch
from
962c5dc to
3790adc
Compare
jsync-swirlds
approved these changes
Jun 10, 2025
AlfredoG87
added
the
Improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Because the
protobuf-sourcesproject no longer uses any of the protobuf plugins – which is on purpose and is correct – Gradle does not know aboutsrc/main/proto. The files are hence not added to the Jar. This currenlty result in publishing an empty Jar, which is not the goal here I presume.Related Issue(s)
Follow up to: #1219
Discovered while testing: #1281