-
Notifications
You must be signed in to change notification settings - Fork 8
docs: Revise Simulator Documentation #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mustafauzunn
wants to merge
8
commits into
hiero-ledger:main
Choose a base branch
from
mustafauzunn:407-revise-simulator-documentation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
docs: Revise Simulator Documentation #1302
mustafauzunn
wants to merge
8
commits into
hiero-ledger:main
from
mustafauzunn:407-revise-simulator-documentation
+80
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
ata-nas
reviewed
Jun 12, 2025
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating these.
Just a few minor suggestions.
...-and-tests/simulator/src/main/java/org/hiero/block/simulator/config/data/ConsumerConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
…407-revise-simulator-documentation
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Signed-off-by: Mustafa Uzun <mustafa.uzun@limechain.tech>
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1302 +/- ##
============================================
- Coverage 80.81% 80.76% -0.05%
+ Complexity 956 954 -2
============================================
Files 111 111
Lines 4253 4253
Branches 449 449
============================================
- Hits 3437 3435 -2
- Misses 636 637 +1
- Partials 180 181 +1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
jsync-swirlds
approved these changes
Jun 13, 2025
ata-nas
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pull request
label to get past the "label required" check when no label is needed or appropriate.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Enhance simulator configuration documentation
Related Issue(s)
Fixes #407