chore: Remove BlockAcknowledgement.block_root_hash from Publisher API #1407
+49
−130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
added
Feature Enhancement
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
requested review from
mattp-swirldslabs,
ata-nas,
jsync-swirlds and
AlfredoG87
ata-nas
reviewed
Jul 23, 2025
There was a problem hiding this comment.
LG, I have a concern however for the simulator startup data. @AlfredoG87 this could interfere with you long-running tests?
| @@ -66,8 +66,7 @@ public void onNext(final PublishStreamResponse publishStreamResponse) { | |||
| if (publishStreamResponse.hasAcknowledgement()) { | |||
| final BlockAcknowledgement ack = publishStreamResponse.getAcknowledgement(); | |||
| try { | |||
| startupData.updateLatestAckBlockStartupData( | |||
| ack.getBlockNumber(), ack.getBlockRootHash().toByteArray()); | |||
| startupData.updateLatestAckBlockStartupData(ack.getBlockNumber()); | |||
There was a problem hiding this comment.
Please note that the startup data will stop functioning w/o the hash to be saved on disk. This means that the next startup will be w/o previous hash and everything will be broken after that. We should add a way to save the current hash (as it is generated by the simulator) and then retrieving and storing that in the proper place once ack is received.
| if (enabled) { | ||
| // @todo(904) we need the correct response code, currently it seems that | ||
| // the response code is not being set correctly? The if check should | ||
| // be different and based on the response code, only saving | ||
| Files.write(latestAckBlockNumberPath, String.valueOf(blockNumber).getBytes()); | ||
| Files.write(latestAckBlockHashPath, blockHash); |
There was a problem hiding this comment.
I do not think we can omit this, we simply need another way to supply the hash.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #1407 +/- ##
============================================
+ Coverage 81.19% 81.26% +0.07%
+ Complexity 994 990 -4
============================================
Files 113 113
Lines 4456 4441 -15
Branches 467 464 -3
============================================
- Hits 3618 3609 -9
+ Misses 634 629 -5
+ Partials 204 203 -1
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
BlockAcknowledgement.block_root_hashis present in the publisher API but outdated and not utilized by CNblock_stream_publish_service.proto)blockHashfrom SimulatorStartupData.updateLatestAckBlockStartupData that was utilized as theblockRootHashon an acknowledged block. ALso simplify logic given fewer casesblockRootHashlogic fromSimulatorStartupDataImplTestlogicSimulatorStartupDataImplTestcoverage withtestFailedInitializationUnavailableBlockNumberFilePublishStreamObserverTestwithverifyUpdateLatestAckBlockStartupDataHandlesIOException()and a correction of BlockAcknowledgment in responseRelated Issue(s)
Fixes #1395