POC: Block item proof POC #733
Draft
+336
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
…, improving handling of completable futures to avoid duplication of work or stales. Most importantly implementation of the MerkleTree completable future on the ConcurrentStreamingTreeHasher Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
|
@AlfredoG87 do we still need this? Shall we consider to abandon this PR? |
|
@ata-nas Indeed I have considered it, and although yes, we will not merge this PR, there are some POC stuff here that we might be able to re-use and make the dev of the feature faster once we get back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
This is a WIP POC.