fix: debug_traceTransaction validation for default tracer #4404
+233
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When tracer is not specified, the second parameter has more fields that are specific to the opcode logger and which will be ignored when tracer field is set to any value, such as
disableStorage
,enableMemory
,disableStack
,fullStorage
. The case when tracer is not specified was missed during implementation, and after implementing stricter validation in 0.70 has resulted in an error. This is the request that Remix makes, hence the bug.Related issue(s)
Fixes #4368
Testing Guide
Changes from original design (optional)
There is a config property
fullStorage
which is not explicitly specified by Geth, but it is passed by Remix, however it is always set to false when passed. In order not to break Remix compatibility, I have added it to the validation, however it will be ignored after that.Additional work needed (optional)
N/A
Checklist