Skip to content

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Sep 23, 2025

Description

When tracer is not specified, the second parameter has more fields that are specific to the opcode logger and which will be ignored when tracer field is set to any value, such as disableStorage, enableMemory, disableStack, fullStorage. The case when tracer is not specified was missed during implementation, and after implementing stricter validation in 0.70 has resulted in an error. This is the request that Remix makes, hence the bug.

Related issue(s)

Fixes #4368

Testing Guide

  1. Run the relay locally from this branch
  2. Open Remix IDE, install the debugger plugin, and use custom external HTTP provider pointing to the local relay URL
  3. Pass a transaction hash to the debugger and click start debugging

Changes from original design (optional)

There is a config property fullStorage which is not explicitly specified by Geth, but it is passed by Remix, however it is always set to false when passed. In order not to break Remix compatibility, I have added it to the validation, however it will be ignored after that.

Additional work needed (optional)

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Copy link

github-actions bot commented Sep 23, 2025

Test Results

 20 files  ±0  265 suites  ±0   18m 51s ⏱️ -10s
729 tests +3  724 ✅ +3  5 💤 ±0  0 ❌ ±0 
745 runs  +3  740 ✅ +3  5 💤 ±0  0 ❌ ±0 

Results for commit db28465. ± Comparison against base commit c5c5433.

♻️ This comment has been updated with latest results.

@simzzz simzzz self-assigned this Sep 23, 2025
@simzzz simzzz added the bug Something isn't working label Sep 23, 2025
@simzzz simzzz added this to the 0.72.0 milestone Sep 23, 2025
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Signed-off-by: Simeon Nakov <simeon.nakov@limechain.tech>
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #4404      +/-   ##
==========================================
+ Coverage   96.10%   96.13%   +0.02%     
==========================================
  Files         121      121              
  Lines       19940    20012      +72     
  Branches     1755     1766      +11     
==========================================
+ Hits        19164    19238      +74     
- Misses        751      752       +1     
+ Partials       25       22       -3     
Flag Coverage Δ
config-service 98.80% <ø> (ø)
relay 90.82% <70.00%> (+0.05%) ⬆️
server 88.82% <ø> (ø)
ws-server 98.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/debug.ts 99.37% <100.00%> (+0.35%) ⬆️
packages/relay/src/lib/types/ITracerConfig.ts 100.00% <100.00%> (ø)
...ckages/relay/src/lib/types/ITracerConfigWrapper.ts 100.00% <100.00%> (ø)
packages/relay/src/lib/validators/objectTypes.ts 99.04% <100.00%> (+0.16%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@simzzz simzzz marked this pull request as ready for review September 23, 2025 11:51
@simzzz simzzz requested review from a team as code owners September 23, 2025 11:51
@simzzz simzzz requested a review from natanasow September 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debug_traceTransaction throws error in Remix IDE
1 participant