feat: Мove creation of redis client outside of cache service #4409
+417
−419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#4398) Signed-off-by: nikolay <n.atanasow94@gmail.com>
…olService` interface (#4405) Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
force-pushed
the
4387-move-creation-of-redis-client-outside-of-cache-service
branch
from
7db1dd3 to
c32ceda
Compare
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
commented
Sep 29, 2025
| * | ||
| * @returns {Promise<void>} A Promise that resolves when the client is connected. | ||
| */ | ||
| async connectRedisClient(): Promise<void> { |
There was a problem hiding this comment.
These methods are deleted, since they were only used in tests
konstantinabl
added
the
internal
natanasow
approved these changes
Sep 30, 2025
konstantinabl
changed the title
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
konstantinabl
force-pushed
the
feat/transaction-pool
branch
from
840a110 to
4066a23
Compare
…/transaction-pool
…/transaction-pool
simzzz
reviewed
Sep 30, 2025
| * @returns {Promise<void>} A Promise that resolves when the cache is cleared. | ||
| */ | ||
| async clear(): Promise<void> { | ||
| await this.client.flushAll(); |
There was a problem hiding this comment.
Not related to the PR, but using flushAll could be dangerous, as it might also delete data related to rate limiting, transaction pool, etc. Perhaps we should look into that
simzzz
approved these changes
Sep 30, 2025
…-client-outside-of-cache-service
konstantinabl
deleted the
4387-move-creation-of-redis-client-outside-of-cache-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR's goal to move the redis client creation out of the RedisCache class, since the client will be reused to connect to Redis for out Transaction Pool feature. On top of this, RedisCache's main purpose is to handle operations for get,set, delete etc from Redis, not maintaining the client.
Related issue(s)
Fixes #4387
Changes from original design (optional)
In our original design, the creation of the redis client and the maintenance of the connection was handled in the Redis Cache class, which breaks the first SOLID principle. Now the creation of the client and the connection is moved to a RedisClientManager class, which will manage the client and any operations on it. All client related methods are removed from RedisCache and CacheService classes.
Notes for Reviewer
We always pass a connected client, so there is no need to re-check here
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/4409/files#diff-244a262ac886fc247f5483123909ff160f65a2acfe6957f1a5b35d58453b725eL307
Redis may not be enabled, then the redisClient will be undefined and we need to switch to LRU cache
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/4409/files#diff-6885de8b57b52c8ab19662969cbcf2d242b9944777fe284d756168a2af093d0dR93
These methods have been deleted, since they were only ever used in tests, which is not a good practice
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/4409/files#diff-6885de8b57b52c8ab19662969cbcf2d242b9944777fe284d756168a2af093d0dL127
These tests have been deleted because they belong in the test file for the new RedisClientManager
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/4409/files#diff-7aaa58f003fccbb2493cf321726c1878a5532f99de9148f2876aae60978722ceL226
https://github.com/hiero-ledger/hiero-json-rpc-relay/pull/4409/files#diff-7aaa58f003fccbb2493cf321726c1878a5532f99de9148f2876aae60978722ceL499
Additional work needed (optional)
N/A
Checklist