-
Notifications
You must be signed in to change notification settings - Fork 88
fix: enable jumbo transaction feature #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e5c998
to
3913616
Compare
19d7bc1
to
a9f2339
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…umbo TX Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
a9f2339
to
b377797
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
b377797
to
0ff4709
Compare
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
714882b
to
f6a29e5
Compare
quiet-node
commented
Oct 8, 2025
.../server/tests/acceptance/data/conformity/overwrites/eth_call/call-callenv-options-eip1559.io
Show resolved
Hide resolved
...rver/tests/acceptance/data/conformity/overwrites/eth_estimateGas/estimate-simple-transfer.io
Show resolved
Hide resolved
This reverts commit 0ff4709. Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
natanasow
approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
konstantinabl
approved these changes
Oct 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4419 +/- ##
==========================================
+ Coverage 96.23% 96.25% +0.01%
==========================================
Files 121 121
Lines 19941 19941
Branches 1754 1754
==========================================
+ Hits 19191 19194 +3
Misses 728 728
+ Partials 22 19 -3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables Jumbo Transaction support by upgrading
@hashgraph/hedera-local
from2.32.5
to2.39.0
, which brings CN@0.66.0 and MN@0.140.0. This major version jump introduces breaking changes that required extensive test updates and fixes to accommodate new network behaviors, including HIP-1084: Zero Cost EthereumTransaction on Success, HIP-1086: Jumbo EthereumTransaction and Mirror Node Modularized ServiceKey Changes:
@hashgraph/hedera-local
2.32.5 → 2.39.0 (CN@0.66.0, MN@0.140.0)JUMBO_TX_ENABLED=false
flag from all test environmentsRelated issue(s)
Fixes #3769
Changes from original design
JUMBO_TX_ENABLED=false
flag from test environments as Jumbo Transaction is now enabled by defaulteth_call
andeth_estimateGas
to match new gas behaviorJUMBO_TX_ENABLED
for specific tests incompatible with Jumbo transactions (via test override)Additional work needed (optional)
This PR will be opened for review once Mirror Node releases version 0.140.0 GA and
@hashgraph/hedera-local
upgrades to that version.N/A
Checklist