Skip to content

Conversation

quiet-node
Copy link
Contributor

@quiet-node quiet-node commented Sep 26, 2025

Description

This PR enables Jumbo Transaction support by upgrading @hashgraph/hedera-local from 2.32.5 to 2.39.0, which brings CN@0.66.0 and MN@0.140.0. This major version jump introduces breaking changes that required extensive test updates and fixes to accommodate new network behaviors, including HIP-1084: Zero Cost EthereumTransaction on Success, HIP-1086: Jumbo EthereumTransaction and Mirror Node Modularized Service

Key Changes:

  • Dependency Upgrade: @hashgraph/hedera-local 2.32.5 → 2.39.0 (CN@0.66.0, MN@0.140.0)
  • Unit Tests: Updated SDK client and sendRawTransaction tests to align with new network behavior
  • Environment Config: Removed JUMBO_TX_ENABLED=false flag from all test environments
  • HIP-1084 Support: Fixed HbarRateLimiter tests for zero-cost successful transactions
  • Conformity Tests: Adjusted gas estimate overwrites for eth_call and eth_estimateGas
  • Precompile Fixes: Resolved HTS precompile call tests due to new KEY_NOT_PROVIDED behavior
  • Contract Deploy: Removed custom gas limit for contract deployments

Related issue(s)

Fixes #3769

Changes from original design

  • Removed JUMBO_TX_ENABLED=false flag from test environments as Jumbo Transaction is now enabled by default
  • Updated HbarRateLimiter tests to account for reduced HBAR burns due to HIP-1084
  • Fixed conformity test overwrites for eth_call and eth_estimateGas to match new gas behavior
  • Disabled JUMBO_TX_ENABLED for specific tests incompatible with Jumbo transactions (via test override)

Additional work needed (optional)

This PR will be opened for review once Mirror Node releases version 0.140.0 GA and @hashgraph/hedera-local upgrades to that version.

N/A

Checklist

  • I've assigned an assignee to this PR and related issue(s) (if applicable)
  • I've assigned a label to this PR and related issue(s) (if applicable)
  • I've assigned a milestone to this PR and related issue(s) (if applicable)
  • I've updated documentation (code comments, README, etc. if applicable)
  • I've done sufficient testing (unit, integration, etc.)

@quiet-node quiet-node added this to the 0.72.0 milestone Sep 26, 2025
@quiet-node quiet-node self-assigned this Sep 26, 2025
@quiet-node quiet-node added the enhancement New feature or request label Sep 26, 2025
Copy link

github-actions bot commented Sep 26, 2025

Test Results

 20 files  ±0  265 suites  ±0   20m 40s ⏱️ - 6m 21s
762 tests ±0  758 ✅ +4  4 💤  - 1  0 ❌  - 3 
778 runs  ±0  774 ✅ +4  4 💤  - 1  0 ❌  - 3 

Results for commit 7429b4b. ± Comparison against base commit 33e6b56.

♻️ This comment has been updated with latest results.

@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests-v3 branch 10 times, most recently from 8e5c998 to 3913616 Compare September 30, 2025 19:24
@simzzz simzzz modified the milestones: 0.72.0, 0.73.0 Oct 2, 2025
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests-v3 branch 11 times, most recently from 19d7bc1 to a9f2339 Compare October 8, 2025 16:23
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…umbo TX

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests-v3 branch from a9f2339 to b377797 Compare October 8, 2025 16:23
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests-v3 branch from b377797 to 0ff4709 Compare October 8, 2025 16:46
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node quiet-node force-pushed the 3769-enable-jumbo-transaction-tests-v3 branch from 714882b to f6a29e5 Compare October 8, 2025 17:43
@quiet-node quiet-node changed the title fix: WIP --- enable jumbo transaction tests fix: enable jumbo transaction feature Oct 8, 2025
This reverts commit 0ff4709.
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@quiet-node
Copy link
Contributor Author

Note for reviewers: The StepSecurity failed because of hedera-local@2.39.0 is too fresh 😅 . This will auto resolved on Oct 10th.

image

@quiet-node quiet-node marked this pull request as ready for review October 10, 2025 01:31
@quiet-node quiet-node requested review from a team as code owners October 10, 2025 01:31
Copy link
Member

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@quiet-node quiet-node merged commit c2c0cd4 into main Oct 13, 2025
86 of 89 checks passed
@quiet-node quiet-node deleted the 3769-enable-jumbo-transaction-tests-v3 branch October 13, 2025 14:34
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main    #4419      +/-   ##
==========================================
+ Coverage   96.23%   96.25%   +0.01%     
==========================================
  Files         121      121              
  Lines       19941    19941              
  Branches     1754     1754              
==========================================
+ Hits        19191    19194       +3     
  Misses        728      728              
+ Partials       22       19       -3     
Flag Coverage Δ
config-service 98.80% <ø> (ø)
relay 91.23% <ø> (ø)
server 88.82% <ø> (ø)
ws-server 98.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Jumbo Transaction tests

4 participants