Skip to content

Fix: 377 Allow commas in urls on data-srcset #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: 377 Allow commas in urls on data-srcset #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c3dcb8
Fix: 377 Allow commas in urls on data-srcset
alvarosabu Aug 1, 2019
3d82b69
Fix: 377 Better detection of separation in srcset in case of newlines
alvarosabu Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,13 @@ function getBestSelectionFromSrcset (el, scale) {
const result = []
const container = el.parentNode
const containerWidth = container.offsetWidth * scale
const splitArg = options.includes(',\n') ? ',\n' : ', '
Copy link

@hsxfjames hsxfjames Nov 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should splitArg be /,\s+/ ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with /,\s+/ and ain't working. With the ,\n works fine.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the /,\s+/ does not work? /,\n/ is not very suitable.


let spaceIndex
let tmpSrc
let tmpWidth

options = options.trim().split(',')
options = options.trim().split(splitArg)

options.map(item => {
item = item.trim()
Expand Down
3 changes: 2 additions & 1 deletion vue-lazyload.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,12 +375,13 @@ function getBestSelectionFromSrcset(el, scale) {
var result = [];
var container = el.parentNode;
var containerWidth = container.offsetWidth * scale;
var splitArg = options.includes(',\n') ? ',\n' : ', ';

var spaceIndex = void 0;
var tmpSrc = void 0;
var tmpWidth = void 0;

options = options.trim().split(',');
options = options.trim().split(splitArg);

options.map(function (item) {
item = item.trim();
Expand Down
Loading