Add turbo frame assertion test helpers #742
Open
+100
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
reviewed
May 29, 2025
lib/turbo/test_assertions.rb
Outdated
Comment on lines
118
to
124
| def assert_turbo_frame(id:, loading: nil, src: nil, target: nil, count: 1, &block) | ||
| selector = %(turbo-frame[id="#{id}"]) | ||
| selector << %([loading="#{loading}"]) if loading | ||
| selector << %([src="#{src}"]) if src | ||
| selector << %([target="#{target}"]) if target | ||
| assert_select selector, count: count, &block | ||
| end |
There was a problem hiding this comment.
What do you think about omitting the count: keyword option, and instead forwarding all remaining options:
Suggested change
| def assert_turbo_frame(id:, loading: nil, src: nil, target: nil, count: 1, &block) | |
| selector = %(turbo-frame[id="#{id}"]) | |
| selector << %([loading="#{loading}"]) if loading | |
| selector << %([src="#{src}"]) if src | |
| selector << %([target="#{target}"]) if target | |
| assert_select selector, count: count, &block | |
| end | |
| def assert_turbo_frame(id:, loading: nil, src: nil, target: nil, **options, &block) | |
| selector = %(turbo-frame[id="#{id}"]) | |
| selector << %([loading="#{loading}"]) if loading | |
| selector << %([src="#{src}"]) if src | |
| selector << %([target="#{target}"]) if target | |
| assert_select selector, **options, &block | |
| end |
There was a problem hiding this comment.
Since frames IDs should be unique, I thought it might make sense to set count to 1 instead of unset which matches 1 or more.
seanpdoyle
reviewed
May 29, 2025
seanpdoyle
reviewed
May 29, 2025
Co-authored-by: Sean Doyle <seanpdoyle@users.noreply.github.com>
Co-authored-by: Sean Doyle <seanpdoyle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds integration test helpers for turbo frames. There are already helpers for turbo streams so this brings Frames into parity with them.