Skip to content

Better handling of error messages #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better handling of error messages #240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31110da
Better handling of error messages
May 3, 2018
8184197
Better handling of error messages
May 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/main/java/com/hp/application/automation/tools/run/UploadAppBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,37 +56,37 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
paths = uploadAppModel.getApplicationPaths();
}
if(mcServerSettingsModel == null){
out.println("Failed to upload app to MC server. Cause: MC url didn't be configured." );
out.println("[ERROR] Failed to upload app to MC server. Cause: MC url hasn't been configured." );
return false;
}else{
mcServerUrl = mcServerSettingsModel.getProperties().getProperty("MobileHostAddress");
out.println(String.format("There are %d apps to be uploaded.", paths.size()));
out.println(String.format("[INFO] There are %d app(s) to be uploaded.", paths.size()));
for(int i=1; i<=paths.size(); i++){
String path = paths.get(i-1).getMcAppPath();
try{
out.println(String.format("starting to upload app %d %s", i, path));
out.println(String.format("[INFO] starting to upload app %d %s", i, path));
if(uploadAppModel.getProxySettings() == null){
app = job.upload(mcServerUrl, uploadAppModel.getMcUserName(),uploadAppModel.getMcPassword(), null, null, null, path);
}else{
app = job.upload(mcServerUrl, uploadAppModel.getMcUserName(),uploadAppModel.getMcPassword(), uploadAppModel.getProxySettings().getFsProxyAddress(),uploadAppModel.getProxySettings().getFsProxyUserName(), uploadAppModel.getProxySettings().getFsProxyPassword(),path);
}
if(app == null){
if(uploadAppModel.isUseProxy()){
out.println(String.format("Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s",
out.println(String.format("[ERROR] Failed to upload app using a proxy. Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s",
mcServerUrl, uploadAppModel.getMcUserName(), uploadAppModel.getProxySettings().getFsProxyAddress()));
}else if(uploadAppModel.isUseAuthentication()){
out.println(String.format("Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s, proxy userName:%s",
out.println(String.format("[ERROR] Failed to upload app with the provided authentication information. url:%s, username:%s, Proxy url:%s, proxy userName:%s",
mcServerUrl, uploadAppModel.getMcUserName(), uploadAppModel.getProxySettings().getFsProxyAddress(), uploadAppModel.getProxySettings().getFsProxyUserName()));
}else{
out.println(String.format("Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s,",
out.println(String.format("[ERROR] Failed to upload app. Cause MC connection info is incorrect. url:%s, username:%s",
mcServerUrl, uploadAppModel.getMcUserName()));
}
build.setResult(Result.FAILURE);
return false;
}
out.println("uploaded app info: " + app.toJSONString());
out.println("[INFO] uploaded app info: " + app.toJSONString());
} catch(FileNotFoundException fnf){
out.println(String.format("Failed to upload app to MC server. Cause: File: %s is not found.", path));
out.println(String.format("[ERROR] Failed to upload app to MC server. Cause: File: %s is not found.", path));
build.setResult(Result.FAILURE);
return false;
} catch (IOException ioe) {
Expand All @@ -97,13 +97,13 @@ public boolean perform(AbstractBuild<?, ?> build, Launcher launcher, BuildListen
build.setResult(Result.ABORTED);
} catch (Exception e){
if(uploadAppModel.isUseProxy()){
out.println(String.format("Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s",
out.println(String.format("[ERROR] Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s",
mcServerUrl, uploadAppModel.getMcUserName(), uploadAppModel.getProxySettings().getFsProxyAddress()));
}else if(uploadAppModel.isUseAuthentication()){
out.println(String.format("Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s, proxy userName:%s",
out.println(String.format("[ERROR] Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s, Proxy url:%s, proxy userName:%s",
mcServerUrl, uploadAppModel.getMcUserName(), uploadAppModel.getProxySettings().getFsProxyAddress(), uploadAppModel.getProxySettings().getFsProxyUserName()));
}else{
out.println(String.format("Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s,",
out.println(String.format("[ERROR] Failed to upload app, Cause MC connection info is incorrect. url:%s, username:%s,",
mcServerUrl, uploadAppModel.getMcUserName()));
}
build.setResult(Result.FAILURE);
Expand Down