Proxy websockets #901
Open
Proxy websockets #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way to test this? This should have tests before I merge it, if a unit test for this is complex I'll do a manual test later. |
|
Well, it relies on another server working with websockets. A unit test could be done, but would require quite a bit of work. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy websockets when --websocket is given.
Relevant issues
Fixes issue #142
I took the PR from @fabioimpe at #528, removed style changes (and made sure not to add any of my own), and removed the changes to the changeOrigin parameter.
And of course, I tested whether it worked, which it does.