Skip to content

[TRANSLATION] Create Korean folder & toctree.yml #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

ahnjj
Copy link

@ahnjj ahnjj commented Feb 18, 2025

What does this PR do?

Create Korean folder for agent course and add toctree file.
Thank you in advance for your review.

Part of #148

Who can review?

Once the tests have passed, anyone in the community is welcome to review the PR.
You can also tag relevant members or contributors who might be interested.
@jeongiin, @harheem

@ahnjj ahnjj marked this pull request as draft February 18, 2025 00:59
@burtenshaw
Copy link
Collaborator

Thanks @ahnjj

I suggest that you translate units 0 and 1 into korean, and we will release that together. Is that ok for you?

@burtenshaw burtenshaw changed the title Create Korean folder & toctree.yml [TRANSLATION] Create Korean folder & toctree.yml Feb 18, 2025
@burtenshaw burtenshaw self-assigned this Feb 18, 2025
@ahnjj
Copy link
Author

ahnjj commented Feb 19, 2025

Thanks @ahnjj

I suggest that you translate units 0 and 1 into korean, and we will release that together. Is that ok for you?

I see! I will translate units 0 and 1 and create a new PR. Thanks for your reply!

@burtenshaw
Copy link
Collaborator

Hi @ahnjj and @harheem , what is the status of this?

@ahnjj
Copy link
Author

ahnjj commented Mar 4, 2025

Hi @ahnjj and @harheem , what is the status of this?

Hi! Thanks for checking in on us.

We’re currently working on Unit 1, having completed Unit 0.
We expect to finish it around this weekend.
Should we try to wrap it up quickly?

Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
@ahnjj
Copy link
Author

ahnjj commented Mar 28, 2025

Structurally, this looks great. I'll just add the build workflows.

Thank you! Seems only approval from maintainer left :) @burtenshaw

@ahnjj ahnjj requested a review from burtenshaw March 28, 2025 15:29
@ahnjj
Copy link
Author

ahnjj commented Mar 31, 2025

Hey @burtenshaw, I’d love to get this translation merged. Please let me know if there’s anything I should update! Appreciate your time!

Copy link
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 😄
Could you update it so it includes all the sections?
These are the files currently causing problems since they don't exist

RuntimeError: The following files are present in the table of contents but do not exist:
- communication/live1
- unit1/get-your-certificate
- communication/next-units
Remove them from ../agents-course/units/ko/_toctree.yml.

@ahnjj
Copy link
Author

ahnjj commented Apr 16, 2025

Thanks for the translation 😄 Could you update it so it includes all the sections? These are the files currently causing problems since they don't exist

RuntimeError: The following files are present in the table of contents but do not exist:
- communication/live1
- unit1/get-your-certificate
- communication/next-units
Remove them from ../agents-course/units/ko/_toctree.yml.

Thx for the help! 🤗 @sergiopaniego
I have just updated it following your advice. Seems only maintainer approval left?

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The building process generates an exception because of an issue in the toctree. Could you review it?
Thanks!

@ahnjj
Copy link
Author

ahnjj commented Apr 28, 2025

The building process generates an exception because of an issue in the toctree. Could you review it? Thanks!

Thank you for your guidance! @sergiopaniego I've resolved the issue and would appreciate your help with the merge.
After that, let's update the remaining chapters as soon as possible!

@simoninithomas simoninithomas mentioned this pull request Apr 28, 2025
3 tasks
@ahnjj
Copy link
Author

ahnjj commented May 15, 2025

@sergiopaniego Sorry for the late check! I've just updated it to match the original. Would appreciate it if you could take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants