-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[TRANSLATION] Create Korean folder & toctree.yml #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks @ahnjj I suggest that you translate units 0 and 1 into korean, and we will release that together. Is that ok for you? |
I see! I will translate units 0 and 1 and create a new PR. Thanks for your reply! |
This reverts commit 3ffdfe8.
Localize quiz1.mdx into Korean
feat(i18n🌐): Add Korean translation for Unit 1 agent documentation
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Thank you! Seems only approval from maintainer left :) @burtenshaw |
Hey @burtenshaw, I’d love to get this translation merged. Please let me know if there’s anything I should update! Appreciate your time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 😄
Could you update it so it includes all the sections?
These are the files currently causing problems since they don't exist
RuntimeError: The following files are present in the table of contents but do not exist:
- communication/live1
- unit1/get-your-certificate
- communication/next-units
Remove them from ../agents-course/units/ko/_toctree.yml.
Thx for the help! 🤗 @sergiopaniego |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The building process generates an exception because of an issue in the toctree. Could you review it?
Thanks!
Thank you for your guidance! @sergiopaniego I've resolved the issue and would appreciate your help with the merge. |
@sergiopaniego Sorry for the late check! I've just updated it to match the original. Would appreciate it if you could take a look. |
What does this PR do?
Create Korean folder for agent course and add toctree file.
Thank you in advance for your review.
Part of #148
Who can review?
Once the tests have passed, anyone in the community is welcome to review the PR.
You can also tag relevant members or contributors who might be interested.
@jeongiin, @harheem