Skip to content

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Oct 2, 2025

What does this PR do?

This PR removes load_in_4bit and load_in_8bit deprecated arguments for v5. This is something that I didn't want to do in a minor release as this might be breaking for a lot of users.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 2, 2025

Could you run a few integration tests to make sure 🙏 Thank you.

Copy link
Contributor

@MekkCyber MekkCyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finallyyyy 🔥 ! Great clean up

@ydshieh ydshieh added the for_v5? label Oct 2, 2025
@SunMarc SunMarc requested a review from ArthurZucker October 2, 2025 14:09
@SunMarc SunMarc mentioned this pull request Oct 9, 2025
Copy link
Contributor

github-actions bot commented Oct 9, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: aya_vision, chameleon, colqwen2, diffllama, emu3, ernie4_5_moe, esm, falcon, gemma

@SunMarc
Copy link
Member Author

SunMarc commented Oct 9, 2025

run-slow: bnb

@SunMarc
Copy link
Member Author

SunMarc commented Oct 9, 2025

run-slow: gemma

Copy link
Contributor

github-actions bot commented Oct 9, 2025

This comment contains run-slow, running the specified jobs:

models: ['models/gemma']
quantizations: [] ...

@SunMarc SunMarc merged commit b44d915 into main Oct 9, 2025
26 of 27 checks passed
@SunMarc SunMarc deleted the rm-bnb-load-in branch October 9, 2025 14:34
@ArthurZucker
Copy link
Collaborator

ArthurZucker commented Oct 9, 2025

hahha have it in #41445 as well for from_pretrained

AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
* [v5] remove load_in_4bit and load_in_8bit

* fix

* reveert

* fix

---------

Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants