-
Notifications
You must be signed in to change notification settings - Fork 30.9k
fix gemma3n case failure #41426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix gemma3n case failure #41426
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8124e2a
fix gemma3n case failure
yao-matrix 4410a9c
Merge branch 'main' into issue-545
yao-matrix 31b0e89
fix style
yao-matrix 160f66c
Update dependency_versions_table.py
yao-matrix d3233ff
Merge branch 'main' into issue-545
yao-matrix eb285b8
change the case argument passing way to make the case PASS,
yao-matrix 4b2a282
fix style
yao-matrix 9011d2e
Merge branch 'main' into issue-545
yao-matrix 30d008a
Merge branch 'main' into issue-545
yao-matrix f25edec
Merge branch 'main' into issue-545
yao-matrix cc375fd
Merge branch 'main' into issue-545
yao-matrix 90fc24e
Merge branch 'main' into issue-545
SunMarc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the case:
When user sets
generation_config = GenerationConfig(max_new_tokens=20, do_sample=False)
, heredo_sample
is False, while global_default_value is alsoFalse
, andmodel_gen_config_value
is True, the current condition cannot distinguish whether the value is explicitly set by user or just the global default, so it just modify it to model default. Add another condition to make sure it happens only when user didn't explicitly specify the value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed this is an issue, and afair we discussed it with @gante after merging the PR with config value overwriting. cc @gante for review