-
Notifications
You must be signed in to change notification settings - Fork 30.9k
Fix bark after #41445 #41645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bark after #41445 #41645
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
""" | ||
) | ||
class BarkModel(BarkPreTrainedModel): | ||
class BarkModel(BarkPreTrainedModel, GenerationMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't change class BarkFineModel(BarkPreTrainedModel):
however. Too many tests fail when I enable it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its good that it fixes is, tho a bit weird as the bark model is not semantically a gernerate model. IDT that's the best solution 👀
I agree, but it has a (and it definitely try to use generation config ) |
As @gante wrote in the codebase,
we see
So after the change #41445, the fix of the failing tests in this PR seems to be natural IMO. |
[For maintainers] Suggested jobs to run (before merge) run-slow: bark |
Merged as approved offline on slack |
* fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
Some Bark model classes are not
GenerationMixin
and have their owngeneration
method.#41445 makes change to
GenerationMixin
and those changes are not applied to those Bark model classes, then causes the bark tests to fail. One example isThis PR adds
GenerationMixin
to those models and the tests pass now.