Skip to content

Upgrade wpcs #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Upgrade wpcs #314

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
38ed674
Upgrade to wpcs 3.0
rmccue Feb 21, 2024
d1770a1
Update configuration to match new rule names
rmccue Feb 21, 2024
85d7477
Switch to new helper functions
rmccue Feb 21, 2024
387f0b5
Update ignore code duplication
rmccue Feb 21, 2024
11e1447
Load NonceVerificationSniff in tests
rmccue Feb 21, 2024
798d137
Update sniff names for ignored short arrays and short ternaries
goldenapples Apr 1, 2024
897b6da
Update allowed custom properties config property name
goldenapples Apr 1, 2024
c5f69a8
Add AllowDynamicProperties annotation for PHP 8.3 compat
goldenapples Apr 2, 2024
4834dfc
Add backslash to AllowDynamicProperties
joeleenk Apr 2, 2024
a13a172
Merge branch 'master' into upgrade-wpcs
kadamwhite Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions HM/Sniffs/Security/EscapeOutputSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
*
* @see https://github.com/WordPress/WordPress-Coding-Standards/issues/1864
*/
#[AllowDynamicProperties]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goldenapples Is this necessary? Seems like we should know the properties being used?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Yeah, this was pretty hacky.

The problem is that $printingFunctions is changed in the parent class from protected to private, so trying to unset items from $this->printingFunctions here is not going to work, and will trigger an accessing dynamic properties warning.

coding-standards/HM/Sniffs/Security/EscapeOutputSniff.php

Lines 54 to 56 in c5f69a8

foreach ( $this->hmSafePrintingFunctions as $function => $val ) {
unset( $this->printingFunctions[ $function ] );
}

This annotation silences the dynamic properties deprecation warning. It does not, however, make the code here work to ignore the safe printing functions.

class EscapeOutputSniff extends WPCSEscapeOutputSniff {
use ExtraSniffCode;

Expand Down