Entrega | Teste Técnico - Challenge Charlie | Eduardo Zaqueu #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 25, 2024 09:50
…ut & WeatherBox funcionalities
…xtDaysWeather logic and funcionality
…tes; add jest for upcoming tests
…seEffect unnecessary chaining
…mpatibility with Next
…odify findNextDaysWeather naming to fit nicely with other helper functions
…e weather based on current date
added 4 commits
May 29, 2024 10:12
…closer to current time. Also adjusts the tests to fit accordingly.
… no weatherArray received
Author
|
Subi um fix de emergência pois testei o projeto durante o fim de semana e notei que a API do OpenWeather, ao ser usada com o parâmetro 'lang' não traz resultados atualizados. Algumas cidade, como o próprio Rio de Janeiro, não retornavam previsões desde o dia 31/05, o que pode impactar diretamente na avaliação do meu teste por conta da falta de atualização da própria API. As previsões ficarão em inglês, pois fazer uma função de tradução necessitaria de uma nova feature que é posterior à entrega. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your name: Eduardo Zaqueu de Oliveira Moreno
Your Github homepage: https://github.com/zaqueu-1
Original challenge URL: https://github.com/hurbcom/challenge-charlie