Skip to content

Conversation

@Zasa-san
Copy link
Collaborator

fixes #8560 #5808 #5508 #5361

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@Zasa-san Zasa-san mentioned this pull request Oct 31, 2025
7 tasks
@Zasa-san
Copy link
Collaborator Author

@mfacar I would like your input on the changes to:

app/api/entities/routes.js
app/react/V2/application/useCases/EntityCompositionUseCase.ts
app/react/V2/infrastructure/repositories/EntityRepository.ts
app/react/V2/infrastructure/repositories/EntityRepositoryImpl.ts

These changes are meant to allow the entity adapter to return the entity with fullText for the entity viewer. I don't know if it conforms to the architecture of the endpoint. I'm also unsure as to how to cover these changes with tests (not for the api file, that one has a test, but the application and infrastructure folder changes).

@mfacar
Copy link
Collaborator

mfacar commented Nov 5, 2025

@mfacar I would like your input on the changes to:

app/api/entities/routes.js app/react/V2/application/useCases/EntityCompositionUseCase.ts app/react/V2/infrastructure/repositories/EntityRepository.ts app/react/V2/infrastructure/repositories/EntityRepositoryImpl.ts

These changes are meant to allow the entity adapter to return the entity with fullText for the entity viewer. I don't know if it conforms to the architecture of the endpoint. I'm also unsure as to how to cover these changes with tests (not for the api file, that one has a test, but the application and infrastructure folder changes).

@Zasa-san, I think the changes align perfectly with the architecture pattern we've established. Regarding testing, I realized I forgot to include some integration tests to cover dependency injection and verify the full end-to-end flow (using mocks for the API calls). I’ve created #8573 to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants