-
Notifications
You must be signed in to change notification settings - Fork 305
feat(satp): adding feature and test for maxretries and maxtimeout #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: satp-stg
Are you sure you want to change the base?
Conversation
Could you resolve DCO errors, your commit is not signed. Be careful with the CI errors. |
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change how the transfer is executed, errors are not throwing, be careful when we are starting in the middle of a transfer(recovering) because there can be messages already received or created in the session... That code was already done and it should not be deleted.
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/core/errors/satp-errors.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
First of all, thank you for all of your feedbacks and for your review. Regarding your comments:
Yes, I already set up the key and signed my first commit, but then there was the problem with the conflicts and that's why we talked yesterday. When I did the commit with you I think forgot to add the signature again
As i said before, the errors are indeed thrown (but inside the executeOperationWithRetriesAndTimeout instead of the previous position). I don't know if this was not clear or maybe the code is not super clean, but I also added in the documentation of the code the way it was functioning. If you think it will be better, i can revert to the previous stage and instead of throwing the error in the auxiliary function i can throw it like it was in the previous code. Thank you again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfilangio01 It looks like there might be a file with special characters in its name added to the diff. Unless there is a very specific purpose and need for it, I'd like to ask that you remove the :monitor:
file.
packages/cactus-plugin-satp-hermes/src/main/typescript/services/gateway/satp-manager.ts
Outdated
Show resolved
Hide resolved
e28231a
to
bba6481
Compare
@sfilangio01 could you please rebase your branch with the latest satp-dev, and re-test? We would like to incorporate your changes soon |
The merge-base changed after approval.
1c1d902
to
4bcb5e1
Compare
f579139
to
840d034
Compare
59c561e
to
65e385e
Compare
Thank you for your contribution. @sfilangio01 please update the MR, rebasing it as per your availability. Please note that we will close stale MRs to cleanup in a close future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The merge-base changed after approval.
5d94456
to
6e2ba18
Compare
6617318
to
83f9482
Compare
Signed-off-by: sfilangio01 <filangerivincenzo01@gmail.com>
fbdd474
to
69e5526
Compare
Introduces a new utility function, executeOperationWithRetriesAndTimeout, which encapsulates retry and timeout logic for SATP step message processing. This update aims to enhance reliability by handling transient failures and timeouts effectively.
Additionally, two new error types are introduced in satp-errors.ts:
Resolves #3744.
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.