feat(connector-besu): add option to use http or ws transport by default #3846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A dedicated endpoint that is purpose-built for solidity events would add a lot of convenience to users. Depends on hyperledger-cacti#3830 Fixes hyperledger-cacti#3825 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Added a new `mainTransport` property to the Besu connector's constructor options which can be set to either `"ws"` or `"http"` depending on what your environment requires for communication with the EVM. Fixes hyperledger-cacti#3845 Depends on hyperledger-cacti#3825 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
requested review from
takeutak,
izuru0,
TheJagpreet,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
This PR/issue depends on:
|
petermetz
changed the title
outSH
approved these changes
Apr 9, 2025
RafaelAPB
approved these changes
Aug 7, 2025
|
This LGTM. However, there are conflicts. @petermetz are you OK with us creating an issue that links to your progress and close the MR for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new
mainTransportproperty to the Besu connector's constructoroptions which can be set to either
"ws"or"http"depending on whatyour environment requires for communication with the EVM.
Fixes #3845
Depends on #3825
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.