part3 upgrade-channel: in case of one chain takes long time for updating and the other chain loses old state

[dai1975]

This is 3rd part of chain query parallelization. see first pullreq for details: #169

Ref: diffs to part2: dai1975#3

• first PR
  • handshake connection
  • handshake channel
• this PR
  • channel upgrade
• later PR
  • relay packets

[Copilot]

Pull Request Overview

This pull request implements chain query parallelization for channel upgrade operations, focusing on scenarios where one chain takes a long time to update while another chain loses old state.

• Introduces debug chain and prover wrappers to simulate network conditions like missing trie nodes and wait times
• Parallelizes chain queries for handshake operations and channel upgrades using goroutines
• Refactors service and command relay logic to execute src→dst and dst→src relay operations concurrently

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
chains/debug/*	Debug wrapper implementations for simulating network conditions during testing
provers/debug/*	Debug prover wrapper for simulating delays and missing state conditions
core/service.go	Parallelized relay service execution with separate goroutines for each direction
core/channel-upgrade.go	Parallelized channel upgrade queries and state collection
core/connection.go	Parallelized connection handshake queries and state collection
core/query.go	Refactored query functions to support individual chain queries
tests/cases/tm2tm/scripts/*	Test scripts with debug environment variables and extended timeouts

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[Copilot]

The sleep duration increased from 20 to 100 seconds. Consider using a smaller value or making it configurable to avoid unnecessarily long test execution times.

Suggested change

	sleep 100 # ibc1 exceeds upgrade.timeout.timestamp
	sleep ${SLEEP_DURATION} # ibc1 exceeds upgrade.timeout.timestamp

[Copilot]

The sleep duration increased from 20 to 100 seconds. Consider using a smaller value or making it configurable to avoid unnecessarily long test execution times.

Suggested change

	sleep 100 # Both chains exceed upgrade.timeout.timestamp
	sleep $SLEEP_DURATION # Both chains exceed upgrade.timeout.timestamp

[Copilot]

The UpdateClients function is commented out but not removed. Consider removing the dead code or documenting why it's preserved.

[Copilot]

Commented out interface method should be removed instead of kept as dead code.

Suggested change

//RelayPackets(ctx context.Context, src, dst *ProvableChain, rp *RelayPackets, sh SyncHeaders, doExecuteRelaySrc, doExecuteRelayDst bool) (*RelayMsgs, error)

[Copilot]

Commented out interface method should be removed instead of kept as dead code.

Suggested change

//RelayAcknowledgements(ctx context.Context, src, dst *ProvableChain, rp *RelayPackets, sh SyncHeaders, doExecuteAckSrc, doExecuteAckDst bool) (*RelayMsgs, error)

[Copilot]

Commented out interface method should be removed instead of kept as dead code.

Suggested change

//UpdateClients(ctx context.Context, src, dst *ProvableChain, doExecuteRelaySrc, doExecuteRelayDst, doExecuteAckSrc, doExecuteAckDst bool, sh SyncHeaders, doRefresh bool) (*RelayMsgs, error)