Skip to content

Conversation

pawlakadrian
Copy link
Contributor

🎫 Issue IBX-10333

Description:

New scenario for hide later content coverage

For QA:

Documentation:

@pawlakadrian pawlakadrian force-pushed the IBX-10333-hide-later-content branch from 7a50371 to f0aaf3e Compare October 3, 2025 11:18
Copy link

sonarqubecloud bot commented Oct 3, 2025

@pawlakadrian
Copy link
Contributor Author

Regression:
OSS: ibexa/oss#243 👍
Commerce: ibexa/commerce#1528 👍

@pawlakadrian pawlakadrian requested a review from a team October 3, 2025 12:40
@ezrobot ezrobot requested review from KamilSznajdrowicz, barbaragr, juskora, katarzynazawada, micszo and tomaszszopinski and removed request for a team October 3, 2025 12:40
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitpicks :)

| title | short_title | intro |
| TestArticleToHideLater | TestArticleToHideLater | TestArticleIntro |
And I'm on Content view Page for "ContentManagement/TestArticleToHideLater"
When I perform the "Hide" action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets only use When/Then once per scenario. Focus of this scenario should a be a scheduler run.

| title | short_title | intro |
| TestArticleToCancelHideLater | TestArticleToCancelHideLater | TestArticleIntro |
And I'm on Content view Page for "ContentManagement/TestArticleToCancelHideLater"
When I perform the "Hide" action
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

use Ibexa\Behat\Browser\Element\Criterion\ElementTextCriterion;
use Ibexa\Behat\Browser\Locator\VisibleCSSLocator;

class CancelContentDialog extends Dialog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that Dialog component should be enough here.
This locator https://github.com/ibexa/admin-ui/blob/main/src/lib/Behat/Component/Dialog.php#L35C47-L35C177 covers Cancel scheduled hiding button
Screenshot 2025-10-06 at 12 22 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants