-
Notifications
You must be signed in to change notification settings - Fork 17
IBX-10333 Added scenario for hide later coverage #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.6
Are you sure you want to change the base?
Conversation
7a50371
to
f0aaf3e
Compare
|
Regression: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nitpicks :)
| title | short_title | intro | | ||
| TestArticleToHideLater | TestArticleToHideLater | TestArticleIntro | | ||
And I'm on Content view Page for "ContentManagement/TestArticleToHideLater" | ||
When I perform the "Hide" action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets only use When/Then once per scenario. Focus of this scenario should a be a scheduler run.
| title | short_title | intro | | ||
| TestArticleToCancelHideLater | TestArticleToCancelHideLater | TestArticleIntro | | ||
And I'm on Content view Page for "ContentManagement/TestArticleToCancelHideLater" | ||
When I perform the "Hide" action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
use Ibexa\Behat\Browser\Element\Criterion\ElementTextCriterion; | ||
use Ibexa\Behat\Browser\Locator\VisibleCSSLocator; | ||
|
||
class CancelContentDialog extends Dialog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that Dialog component should be enough here.
This locator https://github.com/ibexa/admin-ui/blob/main/src/lib/Behat/Component/Dialog.php#L35C47-L35C177 covers Cancel scheduled hiding button
Description:
New scenario for hide later content coverage
For QA:
Documentation: