Skip to content

Correctly persist EmInput entities in CsvFileSink #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Correctly persist EmInput entities in CsvFileSink #1429

wants to merge 9 commits into from

Conversation

pierrepetersmeier
Copy link
Contributor

Resolves #1337

@pierrepetersmeier pierrepetersmeier self-assigned this Sep 1, 2025
@pierrepetersmeier pierrepetersmeier added the bug Something isn't working label Sep 1, 2025
@pierrepetersmeier pierrepetersmeier linked an issue Sep 1, 2025 that may be closed by this pull request
EmInputs aren't written while persisting a JointGridContainer #1337
Open
@pierrepetersmeier pierrepetersmeier marked this pull request as ready for review September 19, 2025 07:44
@staudtMarius
Copy link
Member

@pierrepetersmeier Could you add a test that reads in the persisted grid and compares it with the original grid? There are some test for grids without ems in GridIoIT. Maybe you could simply add some ems to this existing grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staudtMarius staudtMarius Awaiting requested review from staudtMarius

At least 1 approving review is required to merge this pull request.

Assignees

@pierrepetersmeier pierrepetersmeier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EmInputs aren't written while persisting a JointGridContainer
2 participants
@pierrepetersmeier @staudtMarius