Generalize CSV->File #1450
Open
Generalize CSV->File #1450
+481
−323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staudtMarius
requested changes
Oct 7, 2025
| - Change spotless to use googleJavaFormat('1.28.0') [#1409](https://github.com/ie3-institute/PowerSystemDataModel/issues/1409) | ||
| - Change `TimeSeries` to no longer extend `UniqueEntity` [#1441](https://github.com/ie3-institute/PowerSystemDataModel/issues/1441) | ||
|
|
||
| - Refactor CSV handling into shared file-based infrastructure. [#1450](https://github.com/ie3-institute/PowerSystemDataModel/issues/1445) |
There was a problem hiding this comment.
Could you add an empty line below?
| } | ||
| } | ||
|
|
||
| def "The CSV time series meta information source returns correct meta information for a given time series UUID"() { |
There was a problem hiding this comment.
Could you add a check for the file type here?
|
I'll also have a second look at this as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the CSV data handling infrastructure to introduce a shared, extensible file-based connector layer. It generalizes the file connector logic, introduces new metadata classes to support multiple file types, and removes legacy CSV-specific meta information classes. These changes improve code modularity and future extensibility for additional file formats.
File connector infrastructure refactoring:
FileConnectorto encapsulate common file-based source/sink logic, including input stream handling and file path resolution. (src/main/java/edu/ie3/datamodel/io/connectors/FileConnector.java)CsvFileConnectorto extendFileConnector, removing redundant code and centralizing file handling logic. (src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java) [1] [2] [3] [4]File type and metadata generalization:
FileTypeenum to represent supported file types (currently only CSV), with utility methods for file type detection. (src/main/java/edu/ie3/datamodel/io/file/FileType.java)FileIndividualTimeSeriesMetaInformationandFileLoadProfileMetaInformationto replace CSV-specific meta information classes and support file type extensibility. (src/main/java/edu/ie3/datamodel/io/naming/timeseries/FileIndividualTimeSeriesMetaInformation.java,src/main/java/edu/ie3/datamodel/io/naming/timeseries/FileLoadProfileMetaInformation.java) [1] [2]Cleanup and migration to new metadata:
CsvIndividualTimeSeriesMetaInformationandCsvLoadProfileMetaInformationclasses, updating usages throughout the codebase to use the new file-based metadata classes. (src/main/java/edu/ie3/datamodel/io/csv/CsvIndividualTimeSeriesMetaInformation.java,src/main/java/edu/ie3/datamodel/io/csv/CsvLoadProfileMetaInformation.java, other affected files) [1] [2] [3] [4]Documentation and changelog:
CHANGELOG.mdto document the refactoring of CSV handling into a shared file-based infrastructure. (CHANGELOG.md)Package and import adjustments:
TimeSeriesMetaInformationand related classes to theio.naming.timeseriespackage, updating imports across affected files. (src/main/java/edu/ie3/datamodel/io/naming/TimeSeriesMetaInformation.java→src/main/java/edu/ie3/datamodel/io/naming/timeseries/TimeSeriesMetaInformation.java) [1] [2] [3] [4] [5]These changes lay the groundwork for supporting additional file formats beyond CSV, improving maintainability and extensibility.
Closes #1445