Skip to content

Conversation

staudtMarius
Copy link
Member

Resolves #726

@staudtMarius staudtMarius added the enhancement New feature or request label Feb 14, 2023
@staudtMarius staudtMarius added this to the Version 3.1 milestone Feb 14, 2023
@staudtMarius staudtMarius self-assigned this Feb 14, 2023
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Feb 15, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/749.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/ie3-institute/PowerSystemDataModel/749.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

@staudtMarius staudtMarius marked this pull request as ready for review February 15, 2023 11:09
@staudtMarius staudtMarius requested a review from t-ober February 15, 2023 11:09
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job!! Looks very good already. Just some minor details 🙂

@staudtMarius
Copy link
Member Author

!test

@staudtMarius staudtMarius requested a review from t-ober February 21, 2023 12:13
Copy link
Contributor

@t-ober t-ober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - Thanks!

@t-ober t-ober merged commit 968ef93 into dev Feb 22, 2023
@t-ober t-ober deleted the ms/#726-implement-copy-function-for-containers branch February 22, 2023 14:34
@sebastian-peter sebastian-peter added this to the Version 4.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a copy function for SystemParticipants, RawGridElements, JointGridContainer ..

3 participants